Define adapter type maps statically when possible #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rails/rails@c5bf2b4 support is necessary. |
yahonda
force-pushed
the
define_adapter_type_maps_statically_when_possible
branch
from
bce16be
to
dc51934
Compare
|
Now CI is green. Let me squash commits and make this pull request 'Ready for review.' |
yahonda
force-pushed
the
define_adapter_type_maps_statically_when_possible
branch
2 times, most recently
from
a18905d
to
0b3099b
Compare
yahonda
force-pushed
the
define_adapter_type_maps_statically_when_possible
branch
from
0b3099b
to
a19175a
Compare
yahonda
force-pushed
the
define_adapter_type_maps_statically_when_possible
branch
from
a19175a
to
05090c8
Compare
|
@koic Would you review this pull request? The main differences from the previous commits are: |
|
I meant to say the main differences are adding |
koic
approved these changes
Dec 1, 2021
|
Thanks for the review. It gets merged. |
yahonda
deleted the
define_adapter_type_maps_statically_when_possible
branch
andynu
added a commit
to andynu/oracle-enhanced
that referenced
this pull request
Jul 5, 2022
This appears to fix issue rsim#2256. I believe it should have the same memory implications as the intention in rsim#2199. The type maps are loaded once when they are first called. Only one instance of the mapping is ever created. Fortunately this was enough to solve the problem, but if there were a need, this could easily be worked into the clear_cache! API to reset it at a later point in the application just by setting the @type_map to nil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request supports
Define adapter type maps statically when possiblerails/rails#42773 in Active Record Oracle enhanced adapter.Also, to make CI green this pull request needs these additional commits.
_quotetoquote_type_casttotype_cast