Fix cross origin iframe bugs #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These websites will usually have an iframe with src "https://js.stripe.com/v3/m-outer-xxx.html"
1. bugfix 2. add test case 3. add rrweb-all.js to the result of command: bundle:browser 4. make puppeteer headless in CI by default to increase the speed and stability
YunFeng0817
force-pushed
the
fix-cross-origin-iframe
branch
from
6460eae
to
cf50d39
Compare
Juice10
approved these changes
Jan 16, 2023
This was referenced Feb 12, 2023
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 1
Recorder generates error data while recording some websites are integrated with stripe
These websites will usually have an iframe with src "https://js.stripe.com/v3/m-outer-xxx.html"
Reason
The Stripe site has nested iframes and they all have a message proxy to forward messages from child iframe to parent iframe. So cross-origin rrweb messages are also forwarded by this hidden proxy and it makes the recorder generate redundant iframe full snapshots.
Fix
Add an
originproperty to each cross-origin rrweb message for the parent frame to check the integrity of messages.Bug 2
fixes #1077
As Justin's suggestion #1077 (comment), I disabled packing for inter-iframe communication.