Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: recordCrossOriginIframes: true does not work with pack/unpack fn #1077

Closed
1 task done
thatsnotright opened this issue Dec 14, 2022 · 1 comment · Fixed by #1093
Closed
1 task done

[Bug]: recordCrossOriginIframes: true does not work with pack/unpack fn #1077

thatsnotright opened this issue Dec 14, 2022 · 1 comment · Fixed by #1093
Assignees
Labels
bug Something isn't working fixed Issue has been fixed has PR already has pull request for it

Comments

@thatsnotright
Copy link

Preflight Checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.

What package is this bug report for?

rrweb

Version

latest from master

Expected Behavior

I expect recordCrossOriginIframes will show iframe content when injected in to all iframes, with a pack/unpackfn specified.

Actual Behavior

The mutations are captured for iframes but not processed unless I remove the packFn. If I specify a packFn for only the top-level rrweb this also works, so it's just in the child to parent messaging that the packFn causes this behavior.

Steps to Reproduce

Use the repl to get an IFrame site, and then add a packFn and see that it no longer renders cross-domain IFrame content.

I have an idea where to fix this that I'm looking at locally and I can submit a PR if I fix this behavior before anyone else does.

Testcase Gist URL

No response

Additional Information

No response

@thatsnotright thatsnotright added the bug Something isn't working label Dec 14, 2022
@Juice10
Copy link
Contributor

Juice10 commented Jan 6, 2023

Looks like rrweb should disable packing out of the box for inter-iframe communication, then you wouldn't bump into this issue

@Juice10 Juice10 self-assigned this Jan 6, 2023
@YunFeng0817 YunFeng0817 added the has PR already has pull request for it label Jan 16, 2023
@YunFeng0817 YunFeng0817 added the fixed Issue has been fixed label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Issue has been fixed has PR already has pull request for it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants