Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix that addAction wouldn't have any effect without a stop and start #1001

Merged
merged 3 commits into from
Sep 22, 2022
Merged

Fix that addAction wouldn't have any effect without a stop and start #1001

merged 3 commits into from
Sep 22, 2022

Commits on Sep 22, 2022

  1. Fix that addAction wouldn't have any effect without a stop and star… 

    …t - noticed during live mode
    @eoghanmurray
    eoghanmurray committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    4801f21 View commit details
    Browse the repository at this point in the history

  2. Remove addActions as it has a bug-causing replacement of `this.acti… 

    …ons` - refactor to reuse `addAction` and add a `push` fast-track to this function for the common case of adding actions in the correct order
    @eoghanmurray
    eoghanmurray committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    9c570b6 View commit details
    Browse the repository at this point in the history

  3. Apply formatting changes

    @eoghanmurray @github-actions
    eoghanmurray authored and github-actions[bot] committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    6b41521 View commit details
    Browse the repository at this point in the history