Fix that addAction wouldn't have any effect without a stop and start
#1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eoghanmurray
commented
Sep 16, 2022
| @@ -202,7 +201,7 @@ export function createPlayerService( | |||
| syncEvents.push(event); | |||
| } else { | |||
| const castFn = getCastFn(event, false); | |||
| actions.push({ | |||
| timer.addAction({ | |||
| doAction: () => { | |||
| castFn(); | |||
| }, | |||
There was a problem hiding this comment.
addAction directly here should be fine (before we apply syncEvents) because the timer hasn't started yet
eoghanmurray
force-pushed
the
quickfix-live-mode
branch
from
a770801
to
726cb17
Compare
…t - noticed during live mode
…ons` - refactor to reuse `addAction` and add a `push` fast-track to this function for the common case of adding actions in the correct order
eoghanmurray
force-pushed
the
quickfix-live-mode
branch
from
1a87cc9
to
9c570b6
Compare
Yuyz0112
approved these changes
Sep 22, 2022
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addActions(notaddAction) had a bug where it would replacethis.actionsrather than mutating it, causing theactionsarray in therafloop to fail to get new actions (because it still referred to the previous incarnation ofthis.actions)Noticed during live mode where I don't think
addActionsis actually used, so there may be another bug lurking here.