Use git hash for zstd vendor #969
Conversation
CMake ExternalProject_add recommends using a specific git hash with GIT_TAG because branches and tags can be updated to point to different references. https://cmake.org/cmake/help/latest/module/ExternalProject.html This switches zstd_vendor to a git hash. sqlite3_vendor and shared_queues_vendor don't need to be changed because they use URL and URL_MD5 instead. Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
sloretz
requested review from
emersonknapp and
jhdcs
and removed request for
a team
|
There appears to be a build error on Ubuntu Jammy - It's not able to find a build target for Python 3.9? |
Ubuntu Jammy is currently going through a (painful) Python 3.9 -> 3.10 transition. Some of our underlying dependencies haven't been rebuilt, and so things are not working. At the moment, we are relying strictly on builds from https://ci.ros2.org, which doesn't have this problem (due to the way it's Python is setup, which is different than for the PR jobs). Once Jammy sorts itself out with the Python version, PR builds should come back. |
|
CI (build:
|
|
Looks like CI is green 🎉 . @jhdcs if it looks good to you, may I merge this? |
CMake ExternalProject_add recommends using a specific git hash with
GIT_TAG because branches and tags can be updated to point to different
references.
https://cmake.org/cmake/help/latest/module/ExternalProject.html
This switches zstd_vendor to a git hash.
sqlite3_vendor and shared_queues_vendor don't need to be changed because
they use URL and URL_MD5 instead.
Signed-off-by: Shane Loretz sloretz@osrfoundation.org