Skip to content

Commit

Permalink
Use git hash for zstd vendor (#969)
Browse files Browse the repository at this point in the history
CMake ExternalProject_add recommends using a specific git hash with
GIT_TAG because branches and tags can be updated to point to different
references.

https://cmake.org/cmake/help/latest/module/ExternalProject.html

This switches zstd_vendor to a git hash.
sqlite3_vendor and shared_queues_vendor don't need to be changed because
they use URL and URL_MD5 instead.

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
  • Loading branch information
sloretz authored Mar 9, 2022
1 parent cc0e039 commit 9880894
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion zstd_vendor/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ macro(build_zstd)
# We need to configure the CMake command to build from there instead.
ExternalProject_Add(zstd-${zstd_version}
GIT_REPOSITORY https://github.com/facebook/zstd.git
GIT_TAG v${zstd_version}
GIT_TAG 10f0e6993f9d2f682da6d04aa2385b7d53cbb4ee # v${zstd_version}
GIT_CONFIG advice.detachedHead=false
# Suppress git update due to https://gitlab.kitware.com/cmake/cmake/-/issues/16419
# See https://github.com/ament/uncrustify_vendor/pull/22 for details
Expand Down

0 comments on commit 9880894

Please sign in to comment.