Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update tvm version to v0.10.0 #13

Merged
merged 1 commit into from
Nov 23, 2022
Merged

feat: update tvm version to v0.10.0 #13

merged 1 commit into from
Nov 23, 2022

Conversation

wep21
Copy link
Collaborator

@wep21 wep21 commented Nov 12, 2022

tvm v0.10.0 is now released, so I updated the version of tvm.

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
@wep21
Copy link
Collaborator Author

wep21 commented Nov 12, 2022

blocked by autowarefoundation/modelzoo#77 ?

@ambroise-arm
Copy link
Contributor

@wep21 This is not blocked by autowarefoundation/modelzoo#77. The issue listed there concerns compilation. I didn't notice any runtime issue with TVM 0.10, so this can go ahead.

Copy link
Contributor

@ambroise-arm ambroise-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, I hadn't realized you had requested a review.

@@ -53,7 +53,7 @@ endif()

ExternalProject_Add(tvm-build
GIT_REPOSITORY https://github.com/apache/tvm
GIT_TAG v0.9.0
GIT_TAG da7b48f9487c9ee8eb8c6a6d7f80b59969f842c8 # v0.10.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we not targeting v0.10.0?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake ExternalProject_add recommends using a specific git hash with
GIT_TAG because branches and tags can be updated to point to different
references.
ros2/rosbag2#969

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

Copy link
Contributor

@ambroise-arm ambroise-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -53,7 +53,7 @@ endif()

ExternalProject_Add(tvm-build
GIT_REPOSITORY https://github.com/apache/tvm
GIT_TAG v0.9.0
GIT_TAG da7b48f9487c9ee8eb8c6a6d7f80b59969f842c8 # v0.10.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@wep21 wep21 merged commit 9e1accf into main Nov 23, 2022
@wep21 wep21 deleted the feature/update-tvm branch November 23, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants