Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Add missing get_serialized_message_size method. #355

Merged
merged 1 commit into from
May 17, 2019
Merged

Add missing get_serialized_message_size method. #355

merged 1 commit into from
May 17, 2019

Conversation

mjcarroll
Copy link
Member

@mjcarroll mjcarroll commented May 17, 2019 •
edited
Loading

Addresses errors seen by @clalancette Windows Debug CI running tests for rcl

01:26:57.428 10:   'failed to resolve symbol 'rmw_get_serialized_message_size' in shared library 'C:\J\workspace\ci_windows\ws\install\bin/rmw_connext_cpp.dll', at C:\J\workspace\ci_windows\ws\src\ros2\rmw_implementation\rmw_implementation\src\functions.cpp:163

This should have been included in #353 for the addition of preallocation stubs, but was overlooked.

Signed-off-by: Michael Carroll michael@openrobotics.org

@mjcarroll mjcarroll added the bug Something isn't working label May 17, 2019
@mjcarroll mjcarroll self-assigned this May 17, 2019
@mjcarroll mjcarroll added the in progress Actively being worked on (Kanban column) label May 17, 2019
@mjcarroll mjcarroll force-pushed the get_serialized_message_size branch from 1748e17 to 7173e47 Compare May 17, 2019 13:28
@mjcarroll
Add missing get_serialized_message_size method.
5336383 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll force-pushed the get_serialized_message_size branch from 7173e47 to 5336383 Compare May 17, 2019 13:28
clalancette
clalancette approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@mjcarroll
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@dirk-thomas
Copy link
Member

Please add a description to the ticket what problem it fixes and what the symptom is / how to reproduce the fixed problem.

@mjcarroll
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mjcarroll
Copy link
Member Author

macOS CI errors are related to: ros2/build_farmer#199

@mjcarroll mjcarroll merged commit a97d358 into master May 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the get_serialized_message_size branch May 17, 2019 15:00
@mjcarroll mjcarroll removed the in progress Actively being worked on (Kanban column) label May 17, 2019
@clalancette clalancette mentioned this pull request May 17, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clalancette clalancette clalancette approved these changes

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees

@mjcarroll mjcarroll

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjcarroll @dirk-thomas @clalancette