-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source
entry for ai_msgs (jazzy)
#42020
Conversation
I feel like Not sure how many AI cases this msg will cover, feel free to explain it's use, but I see an optional image as input which tells me it might be tailored towards some specific types of AI. Could we have some package name that is closer to the actual task it might be used for? |
The goal of these messages is to convey a prompt to an AI model, whether it's ChatGPT or Google Gemini or Mistral. They all take the same or similar input types. I thought about How about BTW we expect to add more msg types to the package as needed. |
Specifically, I want to use it to:
|
It seems that all of the AI models you mentioned are LLMs, so I would argue that |
Well, those AI models are multimodal now. They can take audio, image, and spreadsheet inputs now, too. I'm not OK with the Here are some ideas which ChatGPT generated for me:
|
Similar to #42014 (review), I recommend |
Package name details$ find . -name "package.xml" -exec grep --color=auto -e "<name>" "{}" ";"
<name>robosoft_ai_msgs</name> License details$ find . -name "package.xml" -exec grep --color=auto -e "<license>" "{}" "+"
<license>Apache-2.0</license> |
How about |
But oepnai is an organization not a system that does something concrete... |
I could do Like I said before, it's very hard to nail down a specific application; the inputs will be many things. |
Will you accept |
Yes, OpenAI is an organization. Robosoft is an organization too. But you guys saw no issues with recommending robosoft_ai_msgs for the name. So what is the problem with openai_msgs? A package of msgs and services meant to interface ROS2 with online services provided by OpenAI, like ChatGPT-4, ChatGPT-4o, DALL-E and whatever they come up with down the road. This "concrete"ness argument made by marcoag should be tossed out immediately. It's vague, arbitrary and found absolutely nowhere in REP-144. But, as per REP-144, the name openai_msgs is more descriptive than robosoft_ai_msgs in that the messages are used to interface ROS2 systems with llms/products/online services offered by OpenAI. And since these are the only products/services offered by OpenAI, I don't believe it is necessary to add additional modifiers like prompt or llm (such as openai_prompt_msgs). |
I think we all agree, if OpenAI ever wants to officially release a ROS package, they can have the package name back. In case that's the holdup. |
@brettpac thanks for your feedback!
If this package was under an
The problem is that these AI tools are used by a number of users. What if someone else wanted to release such a package because they felt their interface definitions were more appropriate? Unless there is some effort made to gain a consensus from the community, like for mocap systems, it wouldn't be fair for an org that is unaffiliated with
imo
@AndyZe I think the deliberating over the right package name now saves the trouble of renaming, updating release repos, making downstream users update their codebase, etc in the future if OpenAI decides to release such a package. Anyways, I recognize this is mine (and Marco's) subjective opinions which may not be shared with other |
Is chatgpt_msgs an option that would be approved? I think it's somewhat hilarious that @AndyZe's original intent for a package that could be used for multiple llms has now gotten narrowed down to just one in order to appease the reviewers and REP-144, but thats the world we live in. But I digress... |
Noting that 4 long-standing, high-level ROS contributors have already deliberated over these message formats/naming. |
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/soliciting-feedback-on-a-msg-package-for-ai-prompting/38587/1 |
@marcoag had approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
This is a new package so I'm adding the
source
entry per https://docs.ros.org/en/jazzy/How-To-Guides/Releasing/Release-Team-Repository.html#create-a-new-release-repositoryThis service is intended for prompting AI models.
@brettpac @yassiezar