-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source
entry for ros2_openai_server (jazzy)
#42014
Conversation
OpenAI is an organization, the name of this package seems a bit misleading on what the actual service is or what is calling. |
I'd be fine with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- At least one of the following must be present
- Top level license file:
- Per package license files:
- License is OSI-approved: Apache License 2.0
- License correctly listed in package.xmls
- Public source repo: https://github.com/robosoft-ai/ros2_openai_server/tree/jazzy
- Source repository contains ROS packages
- Each package meets REP-144 naming conventions
Package name details
$ find . -name "package.xml" -exec grep --color=auto -e "<name>" "{}" ";"
<name>ros2_openai_server</name>
License details
$ find . -name "package.xml" -exec grep --color=auto -e "<license>" "{}" "+"
<license>Apache-2.0</license>
Echoing @marcoag sentiments I too think the naming is very generic and does not pass REP 144. It would be good to properly suffix the package, eg. robosoft_ai_openai_server
. (ros2
can be dropped imo but not a strict requirement).
OK, I can live with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for iterating!
This is a new package so I'm adding the
source
entry per https://docs.ros.org/en/jazzy/How-To-Guides/Releasing/Release-Team-Repository.html#create-a-new-release-repository@brettpac @yassiezar