feat: send nil as a parameter since this is not in request context #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mrigesh Pokhrel <mrigesh.pokhrel@docquity.com>
|
@dongxuny please review |
|
@mrigesh Please bump rk-entry version to v2.2.18 in go.mod file which contains your latest commits. |
Signed-off-by: Mrigesh Pokhrel <mrigesh.pokhrel@docquity.com>
|
@dongxuny done. |
|
I will upgrade rk-entry version in rk-xxx family either. |
|
@dongxuny thank you. This bump should only affect rk-boot, since it's a breaking change. It should not have any effect on other modules. do let me know if anything has to be done on my side. |
|
@mrigesh No problem, I checked other modules, it is good to bump rk-entry version in other module safely. If there is any error occurs while using rk-boot, please upgrade the rk-xxx version. I will finish upgrading rk-xxx module in an hour. |
|
@dongxuny awesome. Sounds good. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support compatibility with rk-entry PR rookie-ninja/rk-entry#72 , post successful merge of rk-entry, rk-boot needs to be updated with new version of rk-ektry