Skip to content

Commit

Permalink
Merge pull request #142 from mrigesh/feat/custom_request_id
Browse files Browse the repository at this point in the history
feat: send nil as a parameter since this is not in request context
  • Loading branch information
dongxuny committed Feb 20, 2023
2 parents b53157f + 69586c2 commit 87c9d49
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
9 changes: 5 additions & 4 deletions boot.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,13 @@ import (
"context"
"embed"
"fmt"
"github.com/rookie-ninja/rk-entry/v2/entry"
"github.com/rookie-ninja/rk-entry/v2/middleware"
"go.uber.org/zap"
"os"
"path/filepath"
"runtime/debug"

rkentry "github.com/rookie-ninja/rk-entry/v2/entry"
rkmid "github.com/rookie-ninja/rk-entry/v2/middleware"
"go.uber.org/zap"
)

type hookFuncM map[string]map[string]func(ctx context.Context)
Expand Down Expand Up @@ -80,7 +81,7 @@ func NewBoot(opts ...BootOption) *Boot {
defer syncLog("N/A")

boot := &Boot{
EventId: rkmid.GenerateRequestId(),
EventId: rkmid.GenerateRequestId(nil),
beforeHookF: newHookFuncM(),
afterHookF: newHookFuncM(),
pluginEntries: map[string]map[string]rkentry.Entry{},
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module github.com/rookie-ninja/rk-boot/v2
go 1.18

require (
github.com/rookie-ninja/rk-entry/v2 v2.2.17
github.com/rookie-ninja/rk-entry/v2 v2.2.18
github.com/stretchr/testify v1.8.0
go.uber.org/zap v1.21.0
)
Expand Down
2 changes: 2 additions & 0 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,8 @@ github.com/rogpeppe/go-internal v1.3.0/go.mod h1:M8bDsm7K2OlrFYOpmOWEs/qY81heoFR
github.com/rogpeppe/go-internal v1.6.1 h1:/FiVV8dS/e+YqF2JvO3yXRFbBLTIuSDkuC7aBOAvL+k=
github.com/rookie-ninja/rk-entry/v2 v2.2.17 h1:cRy6xtjD7B8p5Z1Is0/vrnveDWWOP/3Ouclk4G/rU5Y=
github.com/rookie-ninja/rk-entry/v2 v2.2.17/go.mod h1:P/Fd6Oyvvx0ITbEU2lzO3KkQ9miWVwd84aPaC0LMD0o=
github.com/rookie-ninja/rk-entry/v2 v2.2.18 h1:eGByO/Ycb6BbSsdrfIJwfxy9cdjM+5So7JHaBu6bMko=
github.com/rookie-ninja/rk-entry/v2 v2.2.18/go.mod h1:P/Fd6Oyvvx0ITbEU2lzO3KkQ9miWVwd84aPaC0LMD0o=
github.com/rookie-ninja/rk-logger v1.2.13 h1:ERxeNZUmszlY4xehHcJRXECPtbjYIXzN8yRIyYyLGsg=
github.com/rookie-ninja/rk-logger v1.2.13/go.mod h1:0ZiGn1KsHKOmCv+FHMH7k40DWYSJcj5yIR3EYcjlnLs=
github.com/rookie-ninja/rk-query v1.2.14 h1:aYNyMXixpsEYRfEOz9Npt5QG3A6BQlo9vKjYc78x7bc=
Expand Down

0 comments on commit 87c9d49

Please sign in to comment.