Require at least v2 of jupyter-rsession-proxy #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous versions did not work with latest R or RStudio, which is the primary reason the binder image hasn't been working recently
Without this, there will be no notebook interfaces present.
|
You can test this out in https://mybinder.org/v2/gh/yuvipanda/rocker-binder-template/HEAD?urlpath=rstudio. https://github.com/yuvipanda/rocker-binder-template/blob/0765b74a6af1bef418f425c8fa516d6e81d425ba/Dockerfile#L13 is the extra line I've added, equivalent to this PR |
This was referenced Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous versions did not work with latest R or RStudio,
which is the primary reason the binder image hasn't been working
recently
The other reason the repo wasn't working was because
jupyter notebookwas the start command used, but jupyter-rsession-proxy no longer depended
on the
notebookpackage. I've fixed that by installing notebook and jupyterlab.