-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error running rocker/binder:4.x images #88
Comments
I think this may be related to #78 but not sure... we'll see if the new RStudio is released before I get to investigate properly! |
It could be. I do recall seeing the spinner as well, but only once, so I didn't properly report it. 👍 makes sense to see if the release fixes things. Is there an ETA for the release? I did not find it (might be too stupid though). Will all Binder images receive the latest RStudio release? I tried to pull the latest daily in my own Dockerfile for now, but it's not as simple as I hoped, getting the error
I'm happy to wait a bit though for the problem to solve itself. |
thanks @nuest , looks like the image is a bit out of date (could be an error on my end since I was testing against my local build). Yup, everything should percolate once RStudio is released. I do mean to sink some time into the binder setup (we're trying to standardize things wrt python setup across binder, the ml images, etc so things are consistent) but unfortunately a lot of moving parts still in the air. |
Thank you for the update. I cannot promise much help, this new stack does look quite impressive. I'm surely up for testing though, happy to build and run things locally. Ping me here or directly, if that's helpful. The core Binder team seems to have given up on R a little bit, or just focussing on Conda. So I want rocker/binder to rock :-). |
yeah, feel free to poke around. one of the core tricks that the binder image does is via the pip package, Our campus-hosted system uses this recipe: https://github.com/berkeley-dsep-infra/datahub/blob/staging/deployments/r/image/Dockerfile, which also uses jupter-rsession-proxy and I believe is impacted by the current RStudio disable-auth bug, and has been confirmed to work with the new RStudio release, which is why I'm somewhat hopeful that the problem for I believe @ryanlovett is responsible for much of the magic in |
Hi @cboettig , jupyter-rsession-proxy has gone back and forth between running rsession and rserver, but it now runs rserver. There is still code to run rsession, but there's no entry point for it. And there's no magic to run as non-root. :) There's a pending PR to help it work better as non-root on multi-user systems, but it shouldn't have any trouble in containers. |
Thanks @ryanlovett , this is super helpful. Using the rstudio daily, you're totally right that I can run cc @noamross maybe we should explore some non-root defaults for the rstudio container? Perhaps we could drop the s6-init system by default, leave it as an opt-in configuration for setups where you need it..... thoughts? |
@ryanlovett the permissions issues here really confuse me. it seems strange (wrong?) that I can run |
We are also experiencing this problem in images we are building for the Renku platform - in May using the same rocker base image ( FWIW, I really don't know what to make of this behavior, but after trying several times the redirect eventually self-corrects and I get to a running RStudio session as expected. |
@rokroskar apologies, but can you be more specific? The title issue is about the binder images, and you're not running those images. What problem are you experiencing? The Note that at least on the new images, you should be able to adjust the RStudio version relatively easily by setting the env var RSTUDIO_VERSION and re-running the |
Hi @cboettig sure, sorry for being vague - the problem we are seeing is this redirect to a broken URL when trying to reach the I was able to fix this in the newer images with the rstudio install script as you suggest, but the question remains - is there another docker repository where you push versioned images that can be used to pin our own builds against? In this case the solution was relatively simple, but if something breaks deeper in one of the dependencies it might be really hard to fix and it means that we cannot reliably make new builds of our own that depend on the rocker images. |
Thanks @rokroskar , I follow now. Yes, we intend to pin versions of everything, including RStudio version, in the older containers so that they don't update and break on you. We missed that on the image you mentioned, see https://github.com/rocker-org/rocker-versioned2/blob/master/stacks/core-4.0.0-ubuntu18.04.json#L28, which should be adjusted. R 4.0.0 was released on April 24, and so should be pinned to RStudio 1.2.5042-1. fortunately I think that's the last version where RStudio hadn't broken the disable_auth option in #78. It's fixed in the dailies but the 1.4.x RStudio release isn't out yet, so you could set RStudio version to Apologies we missed the version pinning on the RStudio version. We're a community project here and rely on community reports to catch issues, so thanks again for reporting it! I'll rebuild pinned images now. (Contextual note: this issue is simply related to the RStudio bug, #78, and not related to the issue of running rserver under non-root settings). |
ick, apologies, my math was wrong. 4.0.0 was frozen on the release of 4.0.1, and so should be pinned to 1.3.959-1. |
Aha ok, makes sense now thanks for the explanation! We'll shift to the newer (ubuntu 20.04-based) images soon anyway so hopefully we can stay current that way. |
In case it's of use + interest, I just updated the rocker/binder version used in the robinlovelace/geocompr repo to the latest, as per above, but binder still fails: https://mybinder.org/v2/gh/robinlovelace/geocompr/master?urlpath=rstudio Sad because binder used to work really, really well for teaching. Like @nuest I'm happy to help if I can. |
FWIW the url in the image looks suspicious: https://hub-binder.mybinder.ovh/user/robinlovelace-geocompr-x16nre90/rstudio/https,http:/hub-binder.mybinder.ovh/auth-sign-in?appUri=%2F%3Ftoken%3D6RbyQh4FQn6RyYAajPVo4w |
Hi @Robinlovelace pinning the RStudio version to |
Following instructions from @rokroskar See rocker-org/rocker-versioned2#88 #570
I can confirm that 1.3.959 is the last version of Rstudio that works with
|
Heads-up @rokroskar you advice fixed the issue, many thanks! See commits here for changes: And here for the working RStudio version - will be great to get it working on the latest version of RStudio again. https://mybinder.org/v2/gh/robinlovelace/geocompr/master?urlpath=rstudio |
@Robinlovelace great, glad that helped! I saw somewhere a mention that it also works with some 1.3.x versions of RStudio - did you happen to try? |
No not tried. The fewer changes the better from my perspective so waiting for the released/dev versions to work again and happy to help make that happen. All this sharing will help minimise the fall-out from this issue. |
@rokroskar 1.3.959 is the last version that I have found to work |
Thanks @vnijs , I'm going to pin RStudio version to 1.3.959 in the Pretty annoying that even the RStudio dailies aren't working here, I'm not sure quite why that is but I can reproduce the same 500 error. Given the version issue, I suspect there is still a bug in the current RStudio implementation that needs to be tracked down. Seems unrelated to the previous bug that was also blocking |
@cboettig I assumed that the PR that fixed the |
Heads-up @cboettig this sounds like it may be a future proof solution for the daily version:
From the discussion linked to above. |
Thanks @Robinlovelace , I hadn't seen that. I think it will require a change to jupyter-rsession-proxy, hopefully they can add an ability to let us set that with an environmental variable. |
Happy new year everyone! Just checking up on this issue, potentially an important one for reproducibility, so keen to help out. Any way I can help with this issue @cboettig ? |
Heads-up @cboettig, following various threads I've come across this: https://github.com/kubeflow/kubeflow/pull/5570/files Apparently it works. Hope that helps! |
@Robinlovelace thanks, yes! @davidspek also mentioned this over at #90 (comment). I'm hoping we'll see this as an upstream fix, e.g. jupyterhub/jupyter-rsession-proxy#95 |
This issue seems resolved by #309. |
I think this issue has been resolved, so I close it. |
I have troubles running the
rocker/binder
images for R 4.x.Here is a minimal example repo, based on the README from https://hub.docker.com/r/rocker/binder
https://github.com/nuest/rocker-binder-test
Problem: When I go to "New > RStudio" I do not get RStudio, but am redirected to a weird looking URL with an error message "requested page was not found":
https://hub-binder.mybinder.ovh/user/nuest-rocker-binder-test-g3uxb244/rstudio/https,http:/hub-binder.mybinder.ovh/auth-sign-in
I observe a similar behaviour when running
rocker/binder:4.0.1
, androcker/binder:4.0.2
locally with repo2docker where I'm redirected from http://127.0.0.1:37847/tree to http://127.0.0.1:37847/rstudio to http://127.0.0.1:49189/auth-sign-inand get a 404: not Found error.
These are the logs:
Anyone an idea what's going wrong here?
The text was updated successfully, but these errors were encountered: