Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle unknown type correctly #465

Closed
wants to merge 1 commit into from

Conversation

jog1t
Copy link
Collaborator

@jog1t jog1t commented Jul 17, 2024

fixes OGBEE-60

Copy link
Collaborator Author

jog1t commented Jul 17, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jog1t and the rest of your teammates on Graphite Graphite

@jog1t jog1t requested a review from NathanFlurry July 17, 2024 12:46
@jog1t jog1t self-assigned this Jul 17, 2024
Copy link

linear bot commented Jul 17, 2024

OGBEE-60

@jog1t jog1t force-pushed the 07-14-internal_api_router branch from c7d3511 to d34f925 Compare July 17, 2024 16:33
@jog1t jog1t force-pushed the 07-14-internal_api_router branch 3 times, most recently from 236aa4c to 22b3378 Compare July 24, 2024 23:19
@jog1t jog1t force-pushed the 07-17-fix_handle_unknown_type_correctly branch from a395714 to 365ce66 Compare July 24, 2024 23:19
@jog1t jog1t force-pushed the 07-14-internal_api_router branch from 22b3378 to 696bb48 Compare July 24, 2024 23:27
Copy link
Member

@NathanFlurry NathanFlurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still meant to be a draft?

@jog1t jog1t force-pushed the 07-14-internal_api_router branch 3 times, most recently from e61df9f to ab33c78 Compare August 7, 2024 21:27
@jog1t jog1t force-pushed the 07-17-fix_handle_unknown_type_correctly branch from 365ce66 to c055cc1 Compare August 7, 2024 21:27
@jog1t jog1t force-pushed the 07-14-internal_api_router branch 8 times, most recently from e67c173 to ce67e33 Compare August 7, 2024 23:53
@jog1t jog1t mentioned this pull request Aug 9, 2024
@jog1t jog1t force-pushed the 07-14-internal_api_router branch 2 times, most recently from e698890 to 61b70f1 Compare August 28, 2024 16:40
@jog1t jog1t force-pushed the 07-17-fix_handle_unknown_type_correctly branch from c055cc1 to 3064090 Compare August 28, 2024 16:41
@jog1t jog1t changed the base branch from 07-14-internal_api_router to opengb-editor August 28, 2024 16:41
@jog1t jog1t mentioned this pull request Aug 28, 2024
@jog1t jog1t force-pushed the opengb-editor branch 5 times, most recently from 9126f8b to 0a2c2d3 Compare August 28, 2024 22:49
@NathanFlurry NathanFlurry force-pushed the opengb-editor branch 2 times, most recently from f706ed9 to 65706c7 Compare September 3, 2024 23:24
@NathanFlurry NathanFlurry force-pushed the 07-17-fix_handle_unknown_type_correctly branch from 3064090 to 50fd3ee Compare September 12, 2024 19:10
@NathanFlurry NathanFlurry marked this pull request as ready for review September 12, 2024 19:10
@NathanFlurry
Copy link
Member

Moved to toolchain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants