Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: opengb web ui + internal http api #458

Closed
wants to merge 2 commits into from
Closed

feat: opengb web ui + internal http api #458

wants to merge 2 commits into from

Conversation

jog1t
Copy link
Collaborator

@jog1t jog1t commented Jul 14, 2024

No description provided.

This was referenced Jul 14, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@jog1t Graphite App
Copy link
Collaborator Author

jog1t commented Jul 14, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jog1t and the rest of your teammates on Graphite Graphite

@jog1t jog1t force-pushed the 07-14-internal_api_router branch from 2663132 to 94a5bd4 Compare July 14, 2024 20:15
@jog1t jog1t changed the title internal api router feat: opengb web ui + internal http api Jul 14, 2024
@jog1t jog1t mentioned this pull request Jul 14, 2024
Merged
@NathanFlurry NathanFlurry force-pushed the 07-11-fix_cli_error_when_running_dev_without_tty branch 2 times, most recently from 66b6c7a to 817a70d Compare July 15, 2024 10:49
@jog1t jog1t force-pushed the 07-11-fix_cli_error_when_running_dev_without_tty branch from 817a70d to 8de7fec Compare July 16, 2024 00:35
@jog1t jog1t force-pushed the 07-14-internal_api_router branch from 94a5bd4 to c79bf5f Compare July 16, 2024 00:35
@NathanFlurry NathanFlurry force-pushed the 07-11-fix_cli_error_when_running_dev_without_tty branch from 8de7fec to 853a20d Compare July 16, 2024 09:03
@NathanFlurry NathanFlurry mentioned this pull request Jul 16, 2024
Merged
@jog1t jog1t force-pushed the 07-11-fix_cli_error_when_running_dev_without_tty branch from 853a20d to 9e11bdc Compare July 16, 2024 17:25
@jog1t jog1t force-pushed the 07-14-internal_api_router branch from c79bf5f to 64fc789 Compare July 16, 2024 17:25
@NathanFlurry NathanFlurry force-pushed the 07-11-fix_cli_error_when_running_dev_without_tty branch from 9e11bdc to 0bee6bd Compare July 17, 2024 00:08
This was referenced Jul 17, 2024
Merged
Merged
@NathanFlurry NathanFlurry force-pushed the 07-11-fix_cli_error_when_running_dev_without_tty branch from 0bee6bd to b305457 Compare July 17, 2024 05:08
Base automatically changed from 07-11-fix_cli_error_when_running_dev_without_tty to main July 17, 2024 05:10
@jog1t jog1t force-pushed the 07-14-internal_api_router branch 2 times, most recently from 949dee5 to c7d3511 Compare July 17, 2024 12:20
@jog1t jog1t mentioned this pull request Jul 17, 2024
Closed
@jog1t jog1t force-pushed the 07-14-internal_api_router branch 2 times, most recently from e55373b to 8cbf526 Compare July 18, 2024 20:52
@jog1t jog1t force-pushed the 07-14-internal_api_router branch 2 times, most recently from 22b3378 to 696bb48 Compare July 24, 2024 23:27
NathanFlurry
NathanFlurry requested changes Aug 2, 2024
View reviewed changes
Copy link
Member

@NathanFlurry NathanFlurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see hub review, accidentally mixed the two

packages/runtime/src/server.ts Outdated Show resolved Hide resolved
packages/toolchain/src/build/plan/module.ts Outdated Show resolved Hide resolved
@jog1t jog1t force-pushed the 07-14-internal_api_router branch 8 times, most recently from f19d208 to 8a68701 Compare August 7, 2024 21:54
@jog1t jog1t requested a review from NathanFlurry August 7, 2024 21:56
@jog1t
Copy link
Collaborator Author

jog1t commented Aug 7, 2024

@NathanFlurry lights green in those that I have influence on

NathanFlurry
NathanFlurry requested changes Aug 7, 2024
View reviewed changes
Copy link
Member

@NathanFlurry NathanFlurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we shoudl rename everythign that's named "web" to "editor" for conciseness. "internal-api" is fine.

packages/toolchain/src/internal-api/router.ts Outdated Show resolved Hide resolved
NathanFlurry
NathanFlurry requested changes Aug 7, 2024
View reviewed changes
deno.jsonc Outdated Show resolved Hide resolved
@jog1t jog1t force-pushed the 07-14-internal_api_router branch 3 times, most recently from e67c173 to ce67e33 Compare August 7, 2024 23:53
@jog1t jog1t mentioned this pull request Aug 9, 2024
Merged
NathanFlurry
NathanFlurry approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@NathanFlurry NathanFlurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to fix merge conflicts

@jog1t jog1t force-pushed the 07-14-internal_api_router branch 2 times, most recently from 6bc99fa to e698890 Compare August 28, 2024 15:29
@jog1t
Copy link
Collaborator Author

jog1t commented Aug 28, 2024

Closing in favour of #546

@jog1t jog1t closed this Aug 28, 2024
@jog1t jog1t deleted the 07-14-internal_api_router branch September 3, 2024 23:00
jog1t added a commit to rivet-gg/frontend that referenced this pull request Sep 12, 2024
@jog1t
feat: opengb web (#252)
f5b841c 
Related to rivet-gg/opengb#458
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanFlurry NathanFlurry NathanFlurry approved these changes

Assignees

@jog1t jog1t

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jog1t @NathanFlurry