Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the color from wavedrom files (first batch) #1521

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Remove the color from wavedrom files (first batch) #1521

merged 1 commit into from
Jul 11, 2024

Conversation

kersten1
Copy link
Collaborator

@kersten1 kersten1 requested a review from wmat July 11, 2024 19:26
wmat
wmat approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@wmat wmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm sad the colors are gone.

aswaterman
aswaterman approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, now I know what the type field was there for :)

@aswaterman aswaterman merged commit 58fb684 into main Jul 11, 2024
2 checks passed
@aswaterman aswaterman deleted the Removing-type-from-wavedrom branch July 11, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmat wmat wmat approved these changes

@aswaterman aswaterman aswaterman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kersten1 @wmat @aswaterman