Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSR-12 conversion #29

Commits on Jun 25, 2022

  1. Configuration menu
    Copy the full SHA
    c2bb06a View commit details
    Browse the repository at this point in the history
  2. CS on switch statements

    HLeithner committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    cc5e55e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a9b35cc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3636b98 View commit details
    Browse the repository at this point in the history
  5. Deprecate constant JCOMPAT_UNICODE_PROPERTIES

    Prepare to remove JCOMPAT_UNICODE_PROPERTIES constants from global namespace and replace it with a static variable within the test function. This is a preparation for PSR12 transformation to satisfy PSR1.Files.SideEffects.FoundWithSymbols rule. Beside that it doesn't make sense to declare a global constant which is only used in the local class.
    HLeithner committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    a12b247 View commit details
    Browse the repository at this point in the history
  6. Add phpcs exception for BufferStreamHandler

    The handler auto register should have been removed in Joomla! 4.0.
    HLeithner committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    8eb20eb View commit details
    Browse the repository at this point in the history
  7. Fix phpcs:disable

    HLeithner committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    49a3a61 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    67b5541 View commit details
    Browse the repository at this point in the history
  9. PSR-12 Preparation

    HLeithner committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    37435f2 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. chore: Set permissions for GitHub actions (joomla#38144)

    Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.
    
    - Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions
    
    https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions
    
    https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs
    
    [Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/)
    
    Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
    nathannaveen authored Jun 27, 2022
    Configuration menu
    Copy the full SHA
    7937482 View commit details
    Browse the repository at this point in the history
  2. [4.2] Replace Factory::getApplication() by $this->app in component's …

    …controllers (joomla#38103)
    
    * Replace Factory::getApplication() by $this->app in component's controllers
    
    * Remove un-used import. Thanks @Quy
    
    Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
    Co-authored-by: Quy <quy@fluxbb.org>
    Co-authored-by: Franciska Perisa <9084265+fancyFranci@users.noreply.github.com>
    4 people authored Jun 27, 2022
    Configuration menu
    Copy the full SHA
    e4f622c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    854b373 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    026dc0f View commit details
    Browse the repository at this point in the history
  5. in updates XML always resulted in an error (joomla#38121)

    * <supported_databases> in updates XML always resulted in an error
    * Use uppercase for array key and language string key
    
    Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
    nikosdion and richard67 authored Jun 27, 2022
    Configuration menu
    Copy the full SHA
    0eeae2d View commit details
    Browse the repository at this point in the history
  6. Media Manager Folder Selectory a11y (joomla#38126)

    * Remove the item vue and merge it into the tree vue for ease
    
    * Add accessible keyboard support for the media manager disk view
    wilsonge authored Jun 27, 2022
    Configuration menu
    Copy the full SHA
    8b2cf5a View commit details
    Browse the repository at this point in the history
  7. Refactored WebAuthn with Windows Hello support (joomla#37910)

    * Refactored WebAuthn plugin
    
    * Fix the WebAuthn management page which was broken in joomla#37464
    
    * Fix wrong `@since` doc tag
    
    * Fix docblock typo
    
    * Fix docblock typo
    
    * Fix docblock typo
    
    * Fix docblock typo
    
    * Fix docblock typo
    
    * Fix broken management interface
    
    * Make unnecessarily static method back into non-static
    
    * Replace static helper with injected object
    
    * Come on, commit the ENTIRE file!
    
    * Use the user factory
    
    * Fix error when going through the user factory
    
    * Fix: cannot add WebAuthn authenticator right back after deleting it
    
    * Remove useless switch branch
    
    * Remove useless exception
    
    * Display make and model of the authenticator, if possible
    
    * Add missing JWT signature algorithms
    
    * Fix copyright date
    
    * Fix for PHP 8 using FIDO keys and Android phones
    
    * Reactivate the tooltips after adding an authenticator
    
    * Option to disable the attestation support
    
    * The Windows Hello icon was invisible on white background
    
    * Attempt to fix Appveyor not having Sodium in the Windows build
    
    * Work around third party library bug...
    
    * Create events in a forwards-compatible manner
    
    * Concrete events
    
    * Fix event woes
    
    * Update plugins/system/webauthn/webauthn.xml
    
    Co-authored-by: Brian Teeman <brian@teeman.net>
    
    * Update administrator/language/en-GB/plg_system_webauthn.ini
    
    Co-authored-by: Brian Teeman <brian@teeman.net>
    
    * Improve the layout for editing an authenticator
    
    It now follows the Bootstrap 5 form aesthetic. Moreover,
    there are gaps between the text input and the Save and
    Cancel buttons.
    
    * Confirm deletion of authenticators
    
    * Make the bots happy again
    
    * Code polishing
    
    * Marking classes final
    * Use setApplication / getApplication in the plugin class
    * Remove unused `$db` from the plugin class
    
    * Blind fix
    
    Currently joomla#38060 has broken everything it seems?
    
    * Bring application injection in sync with core
    
    * Remove whitespace
    
    * Add use statement
    
    * Fix wrong event creation in AjaxHandlerLogin
    
    * License change
    
    Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
    Co-authored-by: Brian Teeman <brian@teeman.net>
    Co-authored-by: Roland Dalmulder <contact@rolandd.com>
    Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
    Co-authored-by: Harald Leithner <leithner@itronic.at>
    Co-authored-by: George Wilson <georgejameswilson@googlemail.com>
    7 people authored Jun 27, 2022
    Configuration menu
    Copy the full SHA
    170f91a View commit details
    Browse the repository at this point in the history
  8. Add psr12 converter

    Thanks to @brianteeman
    HLeithner committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    7475255 View commit details
    Browse the repository at this point in the history
  9. Merge pull request joomla#37681 from HLeithner/4.2-psr12-preparation

    PSR12 transformation preparation
    HLeithner authored Jun 27, 2022
    Configuration menu
    Copy the full SHA
    6d9cc0f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    e7f5cc1 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    dd91072 View commit details
    Browse the repository at this point in the history
  12. PSR12

    HLeithner committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    6a01d92 View commit details
    Browse the repository at this point in the history
  13. Merge pull request joomla#37686 from HLeithner/4.2-psr12

    [4.2] Change Codestyle to PSR-12
    HLeithner authored Jun 27, 2022
    Configuration menu
    Copy the full SHA
    09d14c6 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    d90b64d View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    b220ca5 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    cfcf1bb View commit details
    Browse the repository at this point in the history