Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tabbing through the media manager grid #38141

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

wilsonge
Copy link
Contributor

@wilsonge wilsonge commented Jun 25, 2022

Partial Pull Request for Issue #37117

Summary of Changes

Improve focussing on elements within the grid of media manager

  • Does not fix the fact you can't select the selector checkbox in media manager (that's for a future PR) - but does make it selectable.

Testing Instructions

Actual result BEFORE applying this Pull Request

You can tab through the grid elements but have no visible feedback on the toggle items (although you can enter them by hitting enter).

Expected result AFTER applying this Pull Request

Tab through the media manager elements - going over items now allows you to press enter to replace double clicking on them (in terms of opening folders or opening an image to a larger view). You also select the checkbox (it's not selectable still as part of this PR) and can open the action items view. You can leave the actions view from any item by hitting escape

Documentation Changes Required

N/A

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.2-dev labels Jun 25, 2022
@richard67
Copy link
Member

@wilsonge When I have navigated to an action item and then have left it with escape, the image is selected, i.e. the selector checkbox is selected, and it stays like that when I navigate to the next image and so on. Is that one of the known glitches with the selector checkbox which you want to fix with a later PR?

@wilsonge
Copy link
Contributor Author

Yeah it's part of future selector improvements. Plus it's no different to how it works now (you just can see it now)

@richard67
Copy link
Member

I have tested this item ✅ successfully on 6aad873

Works with the mentioned limitations to the selector checkbox.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38141.

@chmst
Copy link
Contributor

chmst commented Jun 26, 2022

I have tested this item ✅ successfully on 6aad873

Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38141.

@richard67 richard67 removed the a11y Accessibility label Jun 26, 2022
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38141.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 26, 2022
@richard67 richard67 added the a11y Accessibility label Jun 26, 2022
@HLeithner HLeithner merged commit 854b373 into joomla:4.2-dev Jun 27, 2022
@HLeithner
Copy link
Member

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 27, 2022
@richard67 richard67 added this to the Joomla! 4.2.0 milestone Jun 27, 2022
@wilsonge wilsonge deleted the feature/media-manager-tab branch June 30, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants