-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow tabbing through the media manager grid #38141
Conversation
16ef9ea
to
6aad873
Compare
@wilsonge When I have navigated to an action item and then have left it with escape, the image is selected, i.e. the selector checkbox is selected, and it stays like that when I navigate to the next image and so on. Is that one of the known glitches with the selector checkbox which you want to fix with a later PR? |
Yeah it's part of future selector improvements. Plus it's no different to how it works now (you just can see it now) |
I have tested this item ✅ successfully on 6aad873 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38141. |
I have tested this item ✅ successfully on 6aad873 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38141. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38141. |
Thanks |
Partial Pull Request for Issue #37117
Summary of Changes
Improve focussing on elements within the grid of media manager
Testing Instructions
Actual result BEFORE applying this Pull Request
You can tab through the grid elements but have no visible feedback on the toggle items (although you can enter them by hitting enter).
Expected result AFTER applying this Pull Request
Tab through the media manager elements - going over items now allows you to press enter to replace double clicking on them (in terms of opening folders or opening an image to a larger view). You also select the checkbox (it's not selectable still as part of this PR) and can open the action items view. You can leave the actions view from any item by hitting escape
Documentation Changes Required
N/A