This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
avoid deadlocks when starting the terraform lifecycle step #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
In #937, a lock was added to prevent the "have all required steps been completed" checker from not including the previous step. This PR modifies the lock logic to first check if all required steps are completed before waiting for the currently running step to complete, and only waiting if there are incomplete steps.
This resolves an issue encountered with some terraform steps that produce large plans.
How I Did it
How to verify it
Description for the Changelog
Resolved an issue encountered with some terraform steps.
Picture of a Ship (not required but encouraged)