This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
finish writing to stepsCompleted before allowing next step to read it #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
Resolved a race condition that could occur when moving to the next step after saving a config.
How I Did it
Added a lock to the complete step management code to ensure that future steps do not attempt to determine what steps have been completed until the previous step has the opportunity to update the list of completed steps.
How to verify it
Description for the Changelog
Resolved a race condition that could occur when moving to the next step after saving a config.
Picture of a Ship (not required but encouraged)