Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(remix-react): add typeof action inference to useFetcher #4392

Merged
merged 3 commits into from
Oct 21, 2022
Merged

feat(remix-react): add typeof action inference to useFetcher #4392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd54069
Support `typeof action` in useFetcher generic type.
michaelhelvey Oct 19, 2022
39e28bf
add myself to the list of contributors
michaelhelvey Oct 19, 2022
21c74e5
Create witty-kiwis-flow.md
pcattori Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/witty-kiwis-flow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"remix": patch
"@remix-run/react": patch
---

Infer the type of the `.data` property of `useFetcher` from `loader` and `action` functions.
Similarly to how you can write useLoaderData<typeof loader>. e.g. you can now write useFetcher<typeof action>, and fetcher.data will be inferred correctly.
Previously, you had to write useFetcher<SerializeFrom<typeof action>>.
1 change: 1 addition & 0 deletions contributors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,7 @@
- michaeldebetaz
- michaeldeboey
- michaelfriedman
- michaelhelvey
- michaseel
- mikeybinnswebdesign
- mirzafaizan
Expand Down
6 changes: 4 additions & 2 deletions packages/remix-react/components.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1436,7 +1436,9 @@ export type FetcherWithComponents<TData> = Fetcher<TData> & {
*
* @see https://remix.run/api/remix#usefetcher
*/
export function useFetcher<TData = any>(): FetcherWithComponents<TData> {
export function useFetcher<TData = any>(): FetcherWithComponents<
SerializeFrom<TData>
MichaelDeBoey marked this conversation as resolved.
Show resolved Hide resolved
> {
let { transitionManager } = useRemixEntryContext();

let [key] = React.useState(() => String(++fetcherId));
Expand All @@ -1446,7 +1448,7 @@ export function useFetcher<TData = any>(): FetcherWithComponents<TData> {
});
let submit = useSubmitImpl(key);

let fetcher = transitionManager.getFetcher<TData>(key);
let fetcher = transitionManager.getFetcher<SerializeFrom<TData>>(key);

let fetcherWithComponents = React.useMemo(
() => ({
Expand Down