feat(remix-react): add typeof action inference to useFetcher
#4392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 21c74e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sergiodxa
approved these changes
Oct 20, 2022
machour
approved these changes
Oct 20, 2022
MichaelDeBoey
changed the title
typeof action inference to useFetchertypeof action inference to useFetcher
MichaelDeBoey
approved these changes
Oct 20, 2022
pcattori
approved these changes
Oct 21, 2022
|
🤖 Hello there, We just published version Thanks! |
MichaelDeBoey
added
the
awaiting release
kentcdodds
pushed a commit
that referenced
this pull request
Dec 15, 2022
* Support `typeof action` in useFetcher generic type. * add myself to the list of contributors * Create witty-kiwis-flow.md Co-authored-by: Pedro Cattori <pcattori@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Issue #: no official issue that I can find, but Kent mentioned in Discord that this would be a good contribution opportunity: https://discord.com/channels/770287896669978684/770287896669978687/1032333166402351154
This PR adds support for inferring the type of the
.dataproperty ofuseFetcherfrom loader and action functions, similarly to how you can writeuseLoaderData<typeof loader>. e.g. you can now writeuseFetcher<typeof action>, andfetcher.datawill be inferred correctly. Previously, you had to writeuseFetcher<SerializeFrom<typeof action>>.Docs:
How should this change best be documented? I struggled to find documentation for the matching changes to
useActionDataanduseLoaderDataoutside of the changelog and thedecisionsdocumentation.Testing strategy:
If there are more official "type-level" tests for this sort of thing, to automate this testing, please point me in the right direction! I pattern-matched off of the similar inference that
useActionDataanduseLoaderDatasupport, and couldn't find any automated tests related to the types.contributing.md.dataproperty of a fetcher (usinguseFetcher<typeof action>) was typed as the action function type, with no inference of the return value.SerializeObject<UndefinedToOptional<{ /* action data */ }>> | undefined