Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix-dev): use native pnp resolution in esbuild 0.15+ #4154

Closed
wants to merge 6 commits into from
Closed

feat(remix-dev): use native pnp resolution in esbuild 0.15+ #4154

wants to merge 6 commits into from

Conversation

redabacha
Copy link
Contributor

Closes: #

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2022

🦋 Changeset detected

Latest commit: e715c19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Major
create-remix Major
remix Major
@remix-run/architect Major
@remix-run/cloudflare Major
@remix-run/cloudflare-pages Major
@remix-run/cloudflare-workers Major
@remix-run/deno Major
@remix-run/eslint-config Major
@remix-run/express Major
@remix-run/netlify Major
@remix-run/node Major
@remix-run/react Major
@remix-run/serve Major
@remix-run/server-runtime Major
@remix-run/vercel Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@redabacha redabacha changed the title feat(dev): use native pnp resolution in esbuild 0.15+ feat(remix-dev): use native pnp resolution in esbuild 0.15+ Sep 7, 2022
@mcansh
Copy link
Collaborator

mcansh commented Sep 29, 2022

i was hoping for this PR 🤩 - i know nothing about pnp though, so I'll defer to @pcattori - but if it's good, perhaps we can bump up to 0.15.9 to also include the jsx name collision fixes :)

packages/remix-dev/package.json Outdated Show resolved Hide resolved
@MichaelDeBoey
Copy link
Member

@redabacha Could you please rebase your branch onto latest dev & resolve conflicts?

@MichaelDeBoey MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label Sep 29, 2022
@redabacha redabacha requested review from MichaelDeBoey and removed request for mcansh September 29, 2022 22:57
@pcattori pcattori self-requested a review September 29, 2022 23:01
@pcattori
Copy link
Contributor

@mcansh : let's do some solid testing on the esbuild upgrade before we merge this

@mcansh
Copy link
Collaborator

mcansh commented Sep 29, 2022

100%

@MichaelDeBoey MichaelDeBoey removed the needs-response We need a response from the original author about this issue/PR label Sep 29, 2022
@mattste
Copy link

mattste commented Sep 30, 2022

I just upgraded my team's very small internal app to this P/R and no issues thus far. I'll update if we run into anything.

@machour
Copy link
Collaborator

machour commented Nov 18, 2022

This have been implemented in #4301
Thank you @redabacha!

@machour machour closed this Nov 18, 2022
@MichaelDeBoey MichaelDeBoey added the pm:yarn3 Bugs related to Yarn 3 label Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants