Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Ensure Form contains splat portion of pathname when no action is specified (#10933)" #10965

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Oct 26, 2023

Reverting because this had some unintended impacts on useFormAction behavior from a layout route when using dynamic params. Will re-open a new PR with a proper fix.

This reverts #10933 (commit 908a40a)

Reopens: #10922

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2023

⚠️ No Changeset found

Latest commit: 4468e5f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11 brophdawg11 linked an issue Oct 26, 2023 that may be closed by this pull request
@brophdawg11 brophdawg11 merged commit 805924d into dev Oct 26, 2023
3 checks passed
@brophdawg11 brophdawg11 deleted the revert-10933-brophdawg11/splat-form-action branch October 26, 2023 18:38
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.18.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 6.18.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: useResolvedPath breaks <Form> when used in a splat route
1 participant