Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Form contains splat portion of pathname when no action is specified #10933

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Oct 13, 2023

The default action for <Form> when no action is specified was being calculated via useResolvedPath("."), however that only includes the pathnameBase so we were losing the splat value.

Given { path: '/foo/*' }, and accessing /foo/bar/baz, <Form> would incorrectly render <Form action="/foo">.

This PR updates the default form action to be useResolvedPath(location.pathname) so we render <Form action="/foo/bar/baz">

Closes #10922

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2023

🦋 Changeset detected

Latest commit: 950853f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router-dom Patch
react-router Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -2894,7 +2894,7 @@ function testDomRouter(
let { container } = render(<RouterProvider router={router} />);

expect(container.querySelector("form")?.getAttribute("action")).toBe(
"/foo?a=1"
"/foo/bar?a=1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was previously asserting the incorrect behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: useResolvedPath breaks <Form> when used in a splat route
2 participants