Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates document template to use exports field for htmlTags #10902

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

dac09
Copy link
Collaborator

@dac09 dac09 commented Jul 2, 2024

Since we have the exports field, we can avoid using @redwoodjs/web/dist - specifically in SSR and RSC templates.

I haven't gone as far as removing the export from the web/index.ts yet though.

@dac09 dac09 added the release:chore This PR is a chore (means nothing for users) label Jul 2, 2024
@dac09 dac09 added this to the chore milestone Jul 2, 2024
@dac09 dac09 enabled auto-merge (squash) July 2, 2024 08:57
@dac09 dac09 disabled auto-merge July 2, 2024 09:01
Copy link
Member

@Tobbe Tobbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this change! Can't wait to do more clean up like this <3

@dac09 dac09 merged commit e87ac80 into redwoodjs:main Jul 2, 2024
51 checks passed
@dac09 dac09 deleted the chore/update-ssr-document-template branch July 2, 2024 09:24
dac09 added a commit to dac09/redwood that referenced this pull request Jul 4, 2024
…rt-serverStore

* 'main' of github.com:redwoodjs/redwood:
  chore(comment): Remove comment that's wrong (redwoodjs#10912)
  chore(esm): Fix project-config dual packaging (redwoodjs#10901)
  RSC: dbAuth in kitchen-sink (redwoodjs#10907)
  RSC: No need to pass location to Router anymore (redwoodjs#10905)
  RSC: Make `rw g page` work for RSC projects (redwoodjs#10903)
  Updates document template to use exports field for htmlTags (redwoodjs#10902)
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, RSC Jul 23, 2024
@Josh-Walker-GM Josh-Walker-GM modified the milestones: RSC, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants