chore(esm): Fix project-config dual packaging #10901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Josh-Walker-GM mind doing a quick scan through? We'll need this when we try to set |
|
Whooops, I misread half of Josh's message and merged it. We can revert if there are any issues here! |
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Jul 4, 2024
…rt-serverStore * 'main' of github.com:redwoodjs/redwood: chore(comment): Remove comment that's wrong (redwoodjs#10912) chore(esm): Fix project-config dual packaging (redwoodjs#10901) RSC: dbAuth in kitchen-sink (redwoodjs#10907) RSC: No need to pass location to Router anymore (redwoodjs#10905) RSC: Make `rw g page` work for RSC projects (redwoodjs#10903) Updates document template to use exports field for htmlTags (redwoodjs#10902)
Josh-Walker-GM
pushed a commit
that referenced
this pull request
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the build and exports for
@redwoodjs/project-config.Before
❌ trying to import project-config with
moduleResolution: nextNow
✅ Can import
This also brings it inline with how we're doing dual packages elsewhere, where we output
dist/*.jsfor ESM anddist/cjs/*.jsfor CJS.