chore(cli): Wrap NodeSSH to make sshExec an instance method #10524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
added
release:chore
Josh-Walker-GM
pushed a commit
that referenced
this pull request
Apr 30, 2024
dac09
added a commit
to dac09/redwood
that referenced
this pull request
May 1, 2024
…e-middleware-client * 'main' of github.com:redwoodjs/redwood: chore(server-auth): Automagic middleware auth on supported providers (dbAuth so far) (redwoodjs#10529) feat(baremetal): Add more details to error messages (redwoodjs#10527) feat(baremetal): Add verbose output to ssh exec (redwoodjs#10525) Fix typos in seo-head (`<Metadata />`) docs (redwoodjs#10526) chore(cli): Wrap NodeSSH to make sshExec an instance method (redwoodjs#10524) Fix broken Azure / MSAL documentation links (redwoodjs#10505) chore(deps): Stop using PR build of rehackt - use proper version (redwoodjs#10523) feat(og-gen): Implement middleware and hooks (redwoodjs#10469) RSC: Rename RSC CI test case (redwoodjs#10521) feat(eslint): Disable restricted $api imports for entryserver (redwoodjs#10520) RSC: Add RSC+SSR smoke test to CI (redwoodjs#10477) fix(dbauth-mw): Use response passed in to middleware (redwoodjs#10516)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring NodeSSH usage in baremetal deploy command to make
sshExecan instance method instead.So that you can do
ssh.exec(...)instead ofsshExec(ssh, ...). Also put the new class I introduced into its own file, becausebaremetal.jsis too long! It's difficult to navigate.The refactor is in preparation of some upcoming changes where I want to be able to customize
sshExecwithout passing more options to every invocation of it.