fix(dbauth-mw): Use response passed in to middleware #10516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dthyresson for reference tagging you here. We already discussed so merging. |
dac09
added a commit
that referenced
this pull request
Apr 26, 2024
…g-gen-mw-p2 * 'main' of github.com:redwoodjs/redwood: RSC: Add RSC+SSR smoke test to CI (#10477) fix(dbauth-mw): Use response passed in to middleware (#10516) Add redwood.toml to `yarn rw info` (#10518) chore(tests): Fix packages/web tests (#10517) fix(dbauth-mw): Unset cookie instead of clearing (#10502) chore(deps): Upgrade to React canary 20240424 (#10513) chore(deps): Upgrade to React Testing Library 14.3.1 (#10514) feat(upgrade): Use GitHub token if available when downloading patches (#10515)
dac09
added a commit
to dac09/redwood
that referenced
this pull request
May 1, 2024
…e-middleware-client * 'main' of github.com:redwoodjs/redwood: chore(server-auth): Automagic middleware auth on supported providers (dbAuth so far) (redwoodjs#10529) feat(baremetal): Add more details to error messages (redwoodjs#10527) feat(baremetal): Add verbose output to ssh exec (redwoodjs#10525) Fix typos in seo-head (`<Metadata />`) docs (redwoodjs#10526) chore(cli): Wrap NodeSSH to make sshExec an instance method (redwoodjs#10524) Fix broken Azure / MSAL documentation links (redwoodjs#10505) chore(deps): Stop using PR build of rehackt - use proper version (redwoodjs#10523) feat(og-gen): Implement middleware and hooks (redwoodjs#10469) RSC: Rename RSC CI test case (redwoodjs#10521) feat(eslint): Disable restricted $api imports for entryserver (redwoodjs#10520) RSC: Add RSC+SSR smoke test to CI (redwoodjs#10477) fix(dbauth-mw): Use response passed in to middleware (redwoodjs#10516)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Middleware can be chained - which means if auth middleware is not the first one on the list of middleware being registered, we need to use the
MiddlewareResponsethat gets passed to the middleware, instead of creating a new one.Also adds test for the positive case where a valid cookie gets decrypted, and sets server auth context.