Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prettier): revert breaking changes in prettier v3 upgrade #10188

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Mar 10, 2024

@Josh-Walker-GM pointed out some breaking changes I included in the prettier v3 upgrade (#10179) in his PR here. My goal with the prettier v3 upgrade was to first do it in a non-breaking way so that it could be released in the next minor, then come back and include the breaking changes (mainly around the tailwind setup command). This should undo the breaking changes so that we can release prettier v3 in the next minor and redo #10182.

@jtoar jtoar added the release:fix This PR is a fix label Mar 10, 2024
@jtoar jtoar added this to the next-release milestone Mar 10, 2024
@jtoar jtoar merged commit 20286e9 into main Mar 10, 2024
39 of 41 checks passed
@jtoar jtoar deleted the ds-prettier-v3/revert-breaking-changes branch March 10, 2024 23:37
jtoar added a commit that referenced this pull request Mar 10, 2024
@Josh-Walker-GM pointed out some breaking changes I included in the
prettier v3 upgrade (#10179) in
his PR [here](#10183). My goal
with the prettier v3 upgrade was to first do it in a non-breaking way so
that it could be released in the next minor, then come back and include
the breaking changes (mainly around the tailwind setup command). This
should undo the breaking changes so that we can release prettier v3 in
the next minor and redo #10182.
jtoar added a commit that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants