fix(cli): avoid require in prettier config during tailwind setup
#10183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
added a commit
that referenced
this pull request
Mar 10, 2024
@Josh-Walker-GM pointed out some breaking changes I included in the prettier v3 upgrade (#10179) in his PR [here](#10183). My goal with the prettier v3 upgrade was to first do it in a non-breaking way so that it could be released in the next minor, then come back and include the breaking changes (mainly around the tailwind setup command). This should undo the breaking changes so that we can release prettier v3 in the next minor and redo #10182.
jtoar
added a commit
that referenced
this pull request
Mar 10, 2024
@Josh-Walker-GM pointed out some breaking changes I included in the prettier v3 upgrade (#10179) in his PR [here](#10183). My goal with the prettier v3 upgrade was to first do it in a non-breaking way so that it could be released in the next minor, then come back and include the breaking changes (mainly around the tailwind setup command). This should undo the breaking changes so that we can release prettier v3 in the next minor and redo #10182.
jtoar
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
@Josh-Walker-GM nice find! That saves us a lot of trouble. I thought at first we'd also have to change the file extension to .mjs since module.exports is CJS-only, but that doesn't seem to be the case. Updated this branch based on my change here: #10188.
jtoar
added a commit
that referenced
this pull request
Mar 12, 2024
…10183) **Problem** With the recent switch to prettier v3 we have some new constraints on how we write our prettier config. One of these is the need to avoid `require` statements. The tailwind setup command in the CLI was adding this to the config file and causing runtime errors on commands like lint. **Changes** 1. Switches the setup command to simply insert the name of the plugin. See [here](https://prettier.io/docs/en/plugins#using-plugins) as to guidance on this. > Strings provided to plugins are ultimately passed to [import() expression](https://nodejs.org/api/esm.html#import-expressions), so you can provide a module/package name, a path, or anything else import() takes. 2. Regenerated the test project fixture and in so doing it bumped the `prettier-plugin-tailwindcss` version. You can also see some formatting for graphql tags have altered as a result of the upgrades. --------- Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
With the recent switch to prettier v3 we have some new constraints on how we write our prettier config. One of these is the need to avoid
requirestatements. The tailwind setup command in the CLI was adding this to the config file and causing runtime errors on commands like lint.Changes
prettier-plugin-tailwindcssversion. You can also see some formatting for graphql tags have altered as a result of the upgrades.