feat: support nesting options via redis:// #942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm having the same issue, which I mistakenly reported at #947 before I noticed this PR. This seems like a more complicated solution than necessary. Wouldn't it be sufficient to conditionally set Added: I see now why that won't work. Is it necessary to put these parameters through the query string, though? I'm assuming that's more a workaround for the way the code is structured. I'm working on an alternate PR. |
This was referenced Aug 20, 2019
ioredis-robot
pushed a commit
that referenced
this pull request
Aug 27, 2019
|
🎉 This issue has been resolved in version 4.14.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jan 16, 2020
This was referenced Jan 24, 2020
This was referenced Feb 22, 2020
This was referenced Mar 19, 2020
This was referenced Apr 17, 2020
janus-dev87
added a commit
to janus-dev87/ioredis-work
that referenced
this pull request
Mar 1, 2024
## [4.14.1](redis/ioredis@v4.14.0...v4.14.1) (2019-08-27) ### Bug Fixes * don’t clobber passed-in tls options with rediss:/ URLs ([#949](redis/ioredis#949)) ([ceefcfa](redis/ioredis@ceefcfa)), closes [#942](redis/ioredis#942) [#940](redis/ioredis#940) [#950](redis/ioredis#950) [#948](redis/ioredis#948)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #940