Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rediss:// url clobbers custom TLS options #947

Closed
paulmelnikow opened this issue Aug 20, 2019 · 1 comment
Closed

rediss:// url clobbers custom TLS options #947

paulmelnikow opened this issue Aug 20, 2019 · 1 comment

Comments

@paulmelnikow
Copy link
Contributor

As mentioned at #939 (comment), the change in #939 clobbers any custom tls value that may be passed in. It would be better to set { tls: true } only when tls isn't already set by the caller.
@paulmelnikow paulmelnikow mentioned this issue Aug 20, 2019
Merged
paulmelnikow added a commit to badges/shields that referenced this issue Aug 20, 2019
@paulmelnikow
Fix TLS errors preventing Redis connections in production
8e5f7ed 
ioredis 4.14.0 introduced an issue where custom TLS options are no longer honored. I reported it here: redis/ioredis#947

For now let's downgrade to the latest working version, which I've confirmed working via the script (checked in).
@paulmelnikow paulmelnikow mentioned this issue Aug 20, 2019
Merged
@paulmelnikow
Copy link
Contributor Author

Sorry, duplicate of #940.

@paulmelnikow paulmelnikow mentioned this issue Aug 20, 2019
Closed
paulmelnikow added a commit to badges/shields that referenced this issue Aug 20, 2019
@paulmelnikow
Fix TLS errors preventing Redis connections in production (#3899)
af81095 
ioredis 4.14.0 introduced an issue where custom TLS options are no longer honored. I reported it here: redis/ioredis#947

This has been preventing the server from using GitHub tokens, however I'm not sure whether or not this has been causing noticeable issues.

For now let's downgrade to the latest working version, which I've confirmed working via the script (checked in).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paulmelnikow