Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Remove unnecessary comment #473

Merged
merged 1 commit into from
May 15, 2020

Conversation

baijum
Copy link
Member

@baijum baijum commented May 15, 2020

Motivation

This cleanup is required to autogenerate CRD from the source.
Refer:
#469 (comment)

Changes

Remove unnecessary comment

Testing

Regular tests should pass.

This cleanup is required to autogenerate CRD from the source.
Refer:
redhat-developer#469 (comment)
@sbose78
Copy link
Member

sbose78 commented May 15, 2020

/lgtm
/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbose78

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #473 into master will decrease coverage by 3.18%.
The diff coverage is 69.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #473      +/-   ##
==========================================
- Coverage   66.26%   63.07%   -3.19%     
==========================================
  Files          21       27       +6     
  Lines        1479     1774     +295     
==========================================
+ Hits          980     1119     +139     
- Misses        377      489     +112     
- Partials      122      166      +44     
Impacted Files Coverage Δ
...r/servicebindingrequest/annotations/annotations.go 0.00% <0.00%> (ø)
...roller/servicebindingrequest/annotations/errors.go 0.00% <0.00%> (ø)
pkg/controller/servicebindingrequest/binder.go 63.75% <ø> (-0.88%) ⬇️
pkg/controller/servicebindingrequest/controller.go 0.00% <0.00%> (ø)
.../controller/servicebindingrequest/nested/nested.go 59.03% <59.03%> (ø)
pkg/controller/servicebindingrequest/reconciler.go 61.44% <59.18%> (+14.87%) ⬆️
...controller/servicebindingrequest/servicecontext.go 59.80% <59.80%> (ø)
...ller/servicebindingrequest/annotations/resource.go 65.65% <65.65%> (ø)
...roller/servicebindingrequest/annotations/secret.go 69.23% <69.23%> (ø)
.../controller/servicebindingrequest/servicebinder.go 64.37% <75.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 179c2fb...6274fa3. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit cd12acd into redhat-developer:master May 15, 2020
DhritiShikhar pushed a commit to DhritiShikhar/service-binding-operator that referenced this pull request May 27, 2020
This cleanup is required to autogenerate CRD from the source.
Refer:
redhat-developer#469 (comment)
@baijum baijum deleted the api-comment branch May 28, 2020 09:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants