Update operator-sdk verion to 0.17.0 #469
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign |
There was a problem hiding this comment.
- Please update PR description/commit with steps how the sources got updated using the new operator-sdk version, i.e. what operations were applied. It would be good add a make rule that can be used for the future.
- travis.yaml should be updated as well
- /blob/179c2fb40bb274eeacace087320b00154a6d0e48/Makefile#L306
- shoudl be updated because this command got removed.
service-binding-operator/Makefile
Line 306 in 179c2fb
- split this PR into at least two commits: one should contain only changes on vendor folder, so that the review is feasible - right now PR contains 913 files.
- should be updated as well
More general question is: how can we be sure that we did not break anything? e2e test should be green and all examples. This has to be checked..
| @@ -255,7 +260,10 @@ spec: | |||
| description: EnvVarPrefix is the prefix for environment variables | |||
| type: string | |||
| mountPathPrefix: | |||
| description: MountPathPrefix is the prefix for volume mount | |||
| description: "Important: Run \"operator-sdk generate k8s\" to regenerate | |||
There was a problem hiding this comment.
not sure if you really want to have this description updated. Actually, you need to fix https://github.com/redhat-developer/service-binding-operator/blob/master/pkg/apis/apps/v1alpha1/servicebindingrequest_types.go#L13 and regenerate.
| github.com/operator-framework/operator-lifecycle-manager v0.0.0-20191115003340-16619cd27fa5 | ||
| github.com/operator-framework/operator-sdk v0.15.2 | ||
| github.com/operator-framework/operator-lifecycle-manager v0.0.0-20200321030439-57b580e57e88 | ||
| github.com/operator-framework/operator-sdk v0.17.0 |
There was a problem hiding this comment.
just to double check - did you follow instructions from here: https://sdk.operatorframework.io/docs/migration/version-upgrade-guide/#v017x ?
| k8s.io/legacy-cloud-providers => k8s.io/legacy-cloud-providers v0.0.0-20191016115753-cf0698c3a16b | ||
| k8s.io/metrics => k8s.io/metrics v0.0.0-20191016113814-3b1a734dba6e | ||
| k8s.io/sample-apiserver => k8s.io/sample-apiserver v0.0.0-20191016112829-06bb3c9d77c9 | ||
| github.com/Azure/go-autorest => github.com/Azure/go-autorest v13.3.2+incompatible // Required by OLM |
There was a problem hiding this comment.
when I left just these two lines, and run go mod tidy, I got:
go: k8s.io/kubernetes@v1.16.2 requires
k8s.io/api@v0.0.0: reading k8s.io/api/go.mod at revision v0.0.0: unknown revision v0.0.0
This cleanup is required to autogenerate CRD from the source. Refer: redhat-developer#469 (comment)
This cleanup is required to autogenerate CRD from the source. Refer: #469 (comment)
This was created to make SDK update a focused one. Refer PR redhat-developer#469 Steps: 1. Update go.mod based on the dependencies from go.mod in OLM: https://github.com/operator-framework/operator-lifecycle-manager/tree/0.14.1 2. Run: go mod tidy 3. Run: go mod vendor 4. Changed test/mocks/mocks.go file based on API changes
|
To reduce the size of this PR and since OLM is not tightly coupled with SDK, I am separating upgrade of OLM into another PR: #474 |
This was created to make SDK update a focused one. Refer PR #469 Steps: 1. Update go.mod based on the dependencies from go.mod in OLM: https://github.com/operator-framework/operator-lifecycle-manager/tree/0.14.1 2. Run: go mod tidy 3. Run: go mod vendor 4. Changed test/mocks/mocks.go file based on API changes
|
@baijum: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
There are some dependency issues when upgrading. For now, I am closing this PR. There is another PR ( #478 ) to upgrade to 0.16.0 version of Operator SDK. |
This cleanup is required to autogenerate CRD from the source. Refer: redhat-developer#469 (comment)
This was created to make SDK update a focused one. Refer PR redhat-developer#469 Steps: 1. Update go.mod based on the dependencies from go.mod in OLM: https://github.com/operator-framework/operator-lifecycle-manager/tree/0.14.1 2. Run: go mod tidy 3. Run: go mod vendor 4. Changed test/mocks/mocks.go file based on API changes
Motivation
Fixes: #449
It's a good practice to upgrade dependencies on a regular basis.
Changes
Updated version.
Testing
For further more details refer the CONTRIBUTING.md