Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move share name parse to sdk #759

Merged
merged 2 commits into from
Dec 11, 2020
Merged

Move share name parse to sdk #759

merged 2 commits into from
Dec 11, 2020

Commits on Dec 11, 2020

  1. Moved shared_subscription parse to SDK part. 

    It is a breaking change for brokers (servers).
I introduced the breaking change by the following reason.

1. It is a part of MQTT protocol. It can avoid the same logic
imprementation by all broker developer.
2. I have a plan that adding protocol error checking more in the SDK.
   For example, the combination of share name and NL:1 is a protocol
   error.
   In order to ckeck these kind of error, I need to parse share name
   at the SDK side.
    @redboltz
    redboltz committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    b0b631c View commit details
    Browse the repository at this point in the history

  2. Update examples.

    @redboltz
    redboltz committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    f140a00 View commit details
    Browse the repository at this point in the history