Move share name parse to sdk #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a breaking change for brokers (servers). I introduced the breaking change by the following reason. 1. It is a part of MQTT protocol. It can avoid the same logic imprementation by all broker developer. 2. I have a plan that adding protocol error checking more in the SDK. For example, the combination of share name and NL:1 is a protocol error. In order to ckeck these kind of error, I need to parse share name at the SDK side.
redboltz
force-pushed
the
move_share_name_parse_to_sdk
branch
from
86b5dde
to
f140a00
Compare
Codecov Report
@@ Coverage Diff @@
## master #759 +/- ##
=======================================
Coverage 85.55% 85.56%
=======================================
Files 60 61 +1
Lines 8549 8554 +5
=======================================
+ Hits 7314 7319 +5
Misses 1235 1235 |
|
This change affects only broker (server) developers. They need to update their subscribe_handler and unsubscribe_handler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.