fix(mm-monitoring): revert the code logic but set to disable as delete #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
| @@ -22,6 +22,7 @@ import ( | |||
| var ( | |||
| ComponentName = "model-mesh" | |||
| Path = deploy.DefaultManifestPath + "/" + ComponentName + "/overlays/odh" | |||
| monitoringPath = deploy.DefaultManifestPath + "/" + "modelmesh-monitoring/base" | |||
There was a problem hiding this comment.
@zdtsw Do we need to pull the modelmesh-monitoring manifests in Dockerfile as well?
There was a problem hiding this comment.
it is still here https://github.com/red-hat-data-services/rhods-operator/blob/rhods-2.5/get_all_manifests.sh#L57 but will need handle in midstream
VaishnaviHire
merged commit d9e63b3
into
red-hat-data-services:rhods-2.5
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://issues.redhat.com/browse/RHOAIENG-293
build 2.4 live: quay.io/wenzhou/rhods-operator-catalog:v2.4.293
build 2.5 live: quay.io/wenzhou/rhods-operator-catalog:v2.5.293 from this PR.
test:
only have modelmesh enabled
check resources
check if resoruce still there
no prometheus CR
no deployment
no SA
cannot find SerivceMonitor modelmesh-federated-metrics