Skip to content

Commit

Permalink
Merge pull request #151 from zdtsw-forking/jira/293
Browse files Browse the repository at this point in the history
fix(mm-monitoring): revert the code logic but set to disable as delete
  • Loading branch information
VaishnaviHire committed Dec 5, 2023
2 parents 79fa917 + e0a0a9a commit d9e63b3
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions components/modelmeshserving/modelmeshserving.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (
var (
ComponentName = "model-mesh"
Path = deploy.DefaultManifestPath + "/" + ComponentName + "/overlays/odh"
monitoringPath = deploy.DefaultManifestPath + "/" + "modelmesh-monitoring/base"
DependentComponentName = "odh-model-controller"
DependentPath = deploy.DefaultManifestPath + "/" + DependentComponentName + "/base"
)
Expand Down Expand Up @@ -146,6 +147,19 @@ func (m *ModelMeshServing) ReconcileComponent(ctx context.Context,
}
}

// Get monitoring namespace
var monitoringNamespace string
if dscispec.Monitoring.Namespace != "" {
monitoringNamespace = dscispec.Monitoring.Namespace
} else {
monitoringNamespace = dscispec.ApplicationsNamespace
}

// Ensure we do not deploy modelmesh-monitoring if it has been there from previous releases
if err = deploy.DeployManifestsFromPath(cli, owner, monitoringPath, monitoringNamespace, ComponentName, false); err != nil {
return err
}

// CloudService Monitoring handling
if platform == deploy.ManagedRhods {
if enabled {
Expand Down

0 comments on commit d9e63b3

Please sign in to comment.