Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add textlint to improve the translation process #42

Merged
merged 5 commits into from
Feb 22, 2019
Merged

Conversation

taehwanno
Copy link
Member

@taehwanno taehwanno commented Feb 21, 2019

This pull request adds textlint in the translation process. As a linter for text and markdown, we can use this for reducing formatting review and eventually can focus on the translation quality itself.

textlint/README.md explains an overview of how we use textlint and how to do maintenance. For proof of improvement, I implement two textlint rules (no-endline-colon, terminology)

You can see the rule implementation test status in CircleCI "Test Textlint" step.

Textlint is already used in Japanese

@taehwanno taehwanno requested a review from a team February 21, 2019 10:02
@netlify
Copy link

netlify bot commented Feb 21, 2019

Deploy preview for ko-reactjs-org ready!

Built with commit 6821f25

https://deploy-preview-42--ko-reactjs-org.netlify.com

Copy link
Member

@gnujoow gnujoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reactjs reactjs deleted a comment from netlify bot Feb 22, 2019
Copy link
Collaborator

@simsim0709 simsim0709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 😄

@taehwanno taehwanno merged commit 2934f63 into master Feb 22, 2019
@taehwanno taehwanno deleted the add/textlint branch February 22, 2019 04:48
@taehwanno
Copy link
Member Author

@taggon @hg-pyun @b9words I got 2 review approval so I merged it.
please check this later and use it for a review!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants