Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have plan when failure happens #18

Closed
1 task done
reactive-firewall opened this issue Feb 24, 2022 · 1 comment
Closed
1 task done

have plan when failure happens #18

reactive-firewall opened this issue Feb 24, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@reactive-firewall
Copy link
Owner

reactive-firewall commented Feb 24, 2022

	catch OSError:
		# call error handler
	finally:

🤔 so when failure happens do we resend or report error?

  • open an issue for this feature

Originally posted by @reactive-firewall in #11 (comment)

@reactive-firewall reactive-firewall added the enhancement New feature or request label Feb 24, 2022
reactive-firewall added a commit that referenced this issue Mar 8, 2022
Initial Stable Base

 - b93f1a6 & 3bea4e8 Initial Setup Scripts and Configs
 - 7758e33 Initial `Makefile`...
 - c03fe27 Initial `README` Document
 - 73f2ce1 Initial requirements file (for python dependancies)
 - 35bd95c Initail `CI` settings for all the things 🎉
 - 60a5685 & a182d34 & 067a294 Initial Tests
   + New project Github Actions for CI testing #10
   + New Minimal Acceptance Testing 731726b
   + New user-install option 53e8a8f
   + Fix for project Build Testing
   + Fix for project Testing Coverage 60dfe04
   + Fix for User-Install Testing ( see #26 )
   + ...and More ( see #1 & #15 & #17 & #29 )

 - 8fc88a8 Cleaned up numerous anti-patterns
 - 4354c2c improved stability of `make clean`
 - 5c94cc7 fix for typos
 - 241922e Fixes for cli argument wrangling ( see #28 & #34 )
 - 7d03fef & 8ba92c3 & b49aee5 Reduced some complexity in test utilities
 - 1ddaa5a Renamed tests by new convention ( see #34 )
 - ...and improved stability throughout project

 - 4ec2e21 & fe25e79 & d7a8ea5 Dropped Travis-CI support due to paywall.
 - 0698978 Python 3.10+ not stable at this time ( see #29 )
 - fd8772e (BREAK-FIX) EOL python 2.x (and so deprecates unstable `setup.py test`)

Initial Point of passing initial tests and such (caveat: low code-coverage)
- [x] Closes #2
- [x] Closes #3
- [x] Closes #4
- [x] Closes #6
- [x] Closes #7
- [x] Closes #8
- [x] Resolved #9
- [x] Closes #12
- [x] Opens #13 🏷️
- [x] Closes #14
- [x] Closes #16
- [x] Closes #17
- [x] Opens #18 🏷️
- [x] Closes #21
- [x] Closes #22
- [x] Closes #23
- [x] Opens #24 🏷️
- [x] Opens #25 🏷️
  - [x] Closes #19
  - [x] Opens #20 🏷️
  - [x] Closes #28
  - [x] Closes #15
- [x] Opens #26 🏷️
- [x] Opens #27 🏷️
- [x] Closes #29
- [x] Closes #30
- [x] Opens #31 🏷️
- [x] Opens #32 🏷️
- [x] Opens #33
- [x] Closes #34
- [x] Opens #35 🏷️
- [x] Closes #36
@reactive-firewall
Copy link
Owner Author

Mcast_basic_fail_diagram

Basic Plan

1. Pre-Action

  • if failure happens in the Pre-Action phase just report and abort.

2. Main Action

  • As input is handled in the Pre-Action phase, failures in the Main Action phase are usually transient in nature and should cause a trivial reattempt and only abort on persistent errors.

3. Post-Action

  • errors in the Post-Action phase are considered warnings and not failures. Ultimately these are out-of-scope and may be handled by reporting an exit-code as an exit would happen either way (crash is a non-fail result here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

1 participant