Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display joins/nicks/parts/quits in single Discord channel #515

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

calebmckay
Copy link

I run a Discord server that maps to 3 IRC channels. When a user joins IRC, they're automatically joined to all 3 channels. Discord users were frustrated when they saw alerts for new messages across 3 channels for a single user joining/quitting.

This pull request expands the functionality of ircStatusNotices in the config to allow users to specify a string value, representing a single Discord channel to display all joins, nick changes, parts, and quits. These messages will display once for each join/nick/quit (no matter how many channels the change is affecting), and display all parts along with the channel name affected.

@coveralls
Copy link

coveralls commented Oct 18, 2019

Coverage Status

Coverage increased (+0.2%) to 97.354% when pulling e83fe71 on calebmckay:single-channel-join-quit into 4fe1483 on reactiflux:master.

@Throne3d
Copy link
Collaborator

Hey! I'm sorry it took me so long to respond to this: I'm probably not going to be reviewing this or merging it anytime soon, as I'm only now maintaining discord-irc for bug fixes and vulnerabilities. (I'm no longer an active user of the project.)

I appreciate the contribution anyway, and hopefully it will be useful to people who come across it! If you have the time to maintain a fork, that might be a way to help keep this project going.

Base automatically changed from master to main January 22, 2021 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants