Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current version not compatible with RN < 0.44 (ViewPropTypes) #1473

Closed
paulmasters opened this issue Jul 13, 2017 · 1 comment
Closed

Current version not compatible with RN < 0.44 (ViewPropTypes) #1473

paulmasters opened this issue Jul 13, 2017 · 1 comment

Comments

@paulmasters
Copy link
Contributor

paulmasters commented Jul 13, 2017 •
edited
Loading

ViewPropTypes replaced View.PropTypes in (I think) RN 0.44
The peerDependency in the package.json says it's compatible with >=0.40 which is wrong.
Would it be possible to test for the existence of ViewPropTypes, and fall back to View.PropTypes to still support older versions?
paulmasters pushed a commit to paulmasters/react-native-maps that referenced this issue Jul 13, 2017
Fall back to View.propTypes if ViewPropTypes is not available (react-…
5e33e1d 
…native-maps#1473)
@dbarros dbarros mentioned this issue Jul 14, 2017
Closed
@i8wu i8wu mentioned this issue Aug 16, 2017
Closed
christopherdro pushed a commit that referenced this issue Aug 28, 2017
@christopherdro
Fall back to View.propTypes if ViewPropTypes is not available (#1473) (…
a713568 
…#1474)
pjaraherrera pushed a commit to pjaraherrera/react-native-maps that referenced this issue Sep 27, 2017
Fall back to View.propTypes if ViewPropTypes is not available (react-…
2c8ddfe 
…native-maps#1473) (react-native-maps#1474)
sorodrigo pushed a commit to Vizzuality/react-native-maps that referenced this issue Oct 23, 2017
Merge branch 'master' of https://github.com/airbnb/react-native-maps …
7c7b8c2 
…into upstream-update

* 'master' of https://github.com/airbnb/react-native-maps:
  v0.17.0
  Update index.d.ts
  v0.16.4
  [MapMarker] fix android release crash on custom marker (react-native-maps#1643)
  Add support for animateToViewingAngle and animateToBearing for Android
  Bump 0.16.3
  Revert "[MapView] revert initialRegion change (react-native-maps#1613)"
  [MapView] revert initialRegion change (react-native-maps#1613)
  Added missing satellite option for iOS Google Maps (react-native-maps#1603)
  Remove legalNotice from android AirMapModule As per https://developers.google.com/android/reference/com/google/android/gms/common/GooglePlayServicesUtil this information does not need to be displayed in app.
  Set initial region on view (react-native-maps#1579)
  Added Typescript Definitions
  Updated "showsIndoorLevelPicker" documentation.
  Added [iOS / Google Maps] support for showsIndoorLevelPicker.
  Fall back to View.propTypes if ViewPropTypes is not available (react-native-maps#1473) (react-native-maps#1474)
  fixe mistakes on circle.md (react-native-maps#1584)
  Add support for AirMap (Native IOS Maps) as suggested on the PR comments.
  Adds support to animateToBearing and animateToViewingAngle functions on IOS.
  fix rare android crashes when map size is 0
  Remove caret from "react": "^16.0.0-alpha.12"
@alvelig
Copy link
Contributor

alvelig commented Dec 12, 2017

I recently made a fresh example build.
https://github.com/alvelig/react-native-maps-example.
Try to check it out or build through the README.MD. If it does not help, let me know.

@alvelig alvelig closed this as completed Dec 12, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alvelig @paulmasters