Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open tool-tip when user clicks a map search result #94

Closed
c3bryant opened this issue Nov 30, 2016 · 7 comments
Closed

Open tool-tip when user clicks a map search result #94

c3bryant opened this issue Nov 30, 2016 · 7 comments

Comments

@c3bryant
Copy link
Contributor

On the new Map Search card, after the user submits a search query, have the Name/Description/Directions bubble automatically show up above the Marker without the user having to physically click on the marker location
@c3bryant c3bryant added this to the Charizard milestone Nov 30, 2016
@i8wu
Copy link
Collaborator

i8wu commented Dec 1, 2016

Bug with react-native-maps not allowing this to be possible right now...investigating

@c3bryant c3bryant removed this from the Charizard milestone Dec 3, 2016
@i8wu
Copy link
Collaborator

i8wu commented Jul 6, 2017

onMapReady callback seems to have just been added, no release yet..but we should keep an eye out react-native-maps/react-native-maps#1369

@i8wu
Copy link
Collaborator

i8wu commented Aug 16, 2017

onMapReady has been released in v0.16.0 of react-native-maps
However, we will not be able to upgrade and take advantage of it until react-native has be upgraded as well react-native-maps/react-native-maps#1473

@c3bryant c3bryant changed the title Map Search: Open tool-tip when user clicks a result Open tool-tip when user clicks a map search result Aug 25, 2017
@c3bryant c3bryant assigned gulci and unassigned vvp002 Jun 20, 2018
@c3bryant c3bryant added this to the Alakazam milestone Jun 20, 2018
@c3bryant
Copy link
Contributor Author

@gulci sending this your way, will you take a look when time permits?

@gulci
Copy link
Contributor

gulci commented Jun 25, 2018

76f34a5 adds functionality to display a tool-tip when a map search result is selected.

@gulci gulci assigned c3bryant and unassigned gulci Jun 25, 2018
@gulci
Copy link
Contributor

gulci commented Jun 25, 2018

Commit 7c01122 resolves an issue with the previous commit where stops would not show up properly when toggling between routes in the map view.

@c3bryant c3bryant modified the milestones: Messaging, Alakazam Jul 3, 2018
@c3bryant c3bryant removed this from the Alakazam milestone Sep 19, 2018
@c3bryant c3bryant removed their assignment Oct 10, 2018
@c3bryant
Copy link
Contributor Author

Merged & verified in dev, closing.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gulci @vvp002 @c3bryant @i8wu