Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the log file to make it easy to follow progress #2021

Merged
merged 1 commit into from
Aug 6, 2022

Conversation

eregon
Copy link
Member

@eregon eregon commented Aug 6, 2022

@eregon
Copy link
Member Author

eregon commented Aug 6, 2022

Example output:

$ ruby-build 2.3.7 ~/.rubies/ruby-2.3.7
To follow progress, use 'tail -f /tmp/ruby-build.20220806124059.87425.log' or pass --verbose
Downloading openssl-1.0.2u.tar.gz...
-> https://dqw8nmjcqpjn7.cloudfront.net/ecd0c6ffb493dd06707d38b14bb4d8c2288bb7033735606569d8f90f89669d16
Installing openssl-1.0.2u...
Installed openssl-1.0.2u to /home/eregon/.rubies/ruby-2.3.7

Downloading ruby-2.3.7.tar.bz2...
-> https://cache.ruby-lang.org/pub/ruby/2.3/ruby-2.3.7.tar.bz2
Installing ruby-2.3.7...

WARNING: ruby-2.3.7 is past its end of life and is now unsupported.
It no longer receives bug fixes or critical security updates.

@@ -1570,6 +1570,10 @@ if [ -n "$VERBOSE" ]; then
tail -f "$LOG_PATH" &
TAIL_PID=$!
trap "kill $TAIL_PID" SIGINT SIGTERM EXIT
else
if [ -z "$RUBY_BUILD_TESTING" ]; then
echo "To follow progress, use 'tail -f $LOG_PATH' or pass --verbose" >&2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done here and not in build_package to avoid to output it twice e.g. when also installing openssl.

@eregon eregon merged commit a753b24 into rbenv:master Aug 6, 2022
@eregon eregon deleted the show-log-file branch August 6, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can the install command have --verbose by default
1 participant