Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the install command have --verbose by default #1721

Closed
vamsipavanmahesh opened this issue Feb 10, 2021 · 7 comments · Fixed by #2021
Closed

Can the install command have --verbose by default #1721

vamsipavanmahesh opened this issue Feb 10, 2021 · 7 comments · Fixed by #2021

Comments

@vamsipavanmahesh
Copy link

When I run the install command:
It just shows "Installing ruby-3.0.0..."
But the end-user has no idea of whether there is progress being made, oftentimes they feel they are stuck
Context: https://stackoverflow.com/a/25210537/1395129

I think a quick solution to fix this is, making the default behavior of the install command show verbose logs

@hsbt hsbt transferred this issue from rbenv/rbenv Feb 14, 2021
@jaydorsey
Copy link

jaydorsey commented Feb 24, 2021

Would love this as well. Something changed semi-recently (I think with ruby-build, but I'm also using asdf-ruby so maybe there) where I no longer get verbose output. (Can try to address this on the asdf-ruby repo if this wasn't the default before)

@eregon
Copy link
Member

eregon commented Jul 11, 2022

I think it's hard to change the default. The whole build output is a lot lot of output, I doubt that is useful.
The ... should make it clear the user needs to wait, it's the same e.g. when installing a C extension.

@eregon eregon closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2022
@jaydorsey
Copy link

jaydorsey commented Jul 13, 2022

It's been a while since I've run into this, but if I remember correctly the reason for this request (at least my reason for chiming in) was that the build was getting stuck on something, and wouldn't show any debug information. It's not that I wasn't sure if i should be waiting or not; there wasn't a great way to debug when it failed.

This made it very hard to debug failures to build when things like openssl wasn't setup correctly, because it wouldn't spit any errors out.

@Crash-m
Copy link

Crash-m commented Aug 3, 2022

I am experiencing the same problem. The build is stuck and I have no idea why. I don't know if I should be waiting or what.

@jaydorsey
Copy link

I am experiencing the same problem. The build is stuck and I have no idea why. I don't know if I should be waiting or what.

If I remember correctly, the way I found the root cause was by inspecting the ruby-build helper in asdf ($HOME/.asdf/plugins/ruby/ruby-build/bin/ruby-build) or the lib/utils.sh file and just doing puts debugging (adding echo statements at various places until I found the error)

@eregon
Copy link
Member

eregon commented Aug 6, 2022

I have never seen a hang during building Ruby, so I think this is then mostly an issue about "how to find out what it's doing on slow machines when building Ruby?".
I think an easy way to address is to print the log and let people look at the log if they feel it takes too long, I'll make a PR for that.

@eregon eregon reopened this Aug 6, 2022
eregon added a commit to eregon/ruby-build that referenced this issue Aug 6, 2022
eregon added a commit to eregon/ruby-build that referenced this issue Aug 6, 2022
eregon added a commit that referenced this issue Aug 6, 2022
@jaydorsey
Copy link

I think this is then mostly an issue about "how to find out what it's doing on slow machines when building Ruby?"

When I first encountered this issue I was on a relatively new M1 macbook.

The actual scenario is a little bit hazy because it's been a while, but I believe it was related to this comment where jemalloc args weren't being recognized as expected, and the ruby build was hanging due to an error finding jemalloc and/or gmp because the flags I was using didn't behave the same (details in that PR).

I think an easy way to address is to print the log and let people look at the log if they feel it takes too long, I'll make a PR for that.

Thank you for this!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants