Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notification): add notification worker e2e test #156

Merged
merged 6 commits into from
Dec 2, 2022
Merged

feat(notification): add notification worker e2e test #156

merged 6 commits into from
Dec 2, 2022

Conversation

mabdh
Copy link
Member

@mabdh mabdh commented Nov 29, 2022 •
edited

  1. fix notification message queue
  2. add e2e notification worker test

@coveralls
Copy link

coveralls commented Nov 29, 2022 •
edited

Pull Request Test Coverage Report for Build 3599554019

  • 35 of 37 (94.59%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 77.827%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/notification/handler.go 0 1 0.0%
plugins/receivers/slack/client.go 30 31 96.77%
Files with Coverage Reduction New Missed Lines %
plugins/receivers/slack/client.go 1 78.61%
Totals Coverage Status
Change from base Build 3581549239: 0.1%
Covered Lines: 2836
Relevant Lines: 3644
💛 - Coveralls

@mabdh mabdh force-pushed the handler-concurrency branch 2 times, most recently from 1e6f934 to 3f14785 Compare November 30, 2022 02:33
@mabdh mabdh marked this pull request as ready for review November 30, 2022 10:51
@mabdh mabdh linked an issue Nov 30, 2022 that may be closed by this pull request
Parallelize notification handler goroutines #158
Open
@mabdh mabdh removed a link to an issue Dec 1, 2022
Parallelize notification handler goroutines #158
Open
@mabdh mabdh changed the title feat(notification): use errgroup for message handler batch size feat(notification): add notification worker e2e test Dec 1, 2022
@mabdh
Copy link
Member Author

mabdh commented Dec 1, 2022

Moving improvement of parallelization to another PR later as more analysis is needed for that

@mabdh mabdh linked an issue Dec 1, 2022 that may be closed by this pull request
Adding notification worker e2e test #159
Closed
@mabdh mabdh merged commit a2bf367 into main Dec 2, 2022
@mabdh mabdh deleted the handler-concurrency branch December 2, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahmatrhd rahmatrhd rahmatrhd approved these changes

@ravisuhag ravisuhag Awaiting requested review from ravisuhag

@ishanarya0 ishanarya0 Awaiting requested review from ishanarya0

@krtkvrm krtkvrm Awaiting requested review from krtkvrm

@rohilsurana rohilsurana Awaiting requested review from rohilsurana

@spy16 spy16 Awaiting requested review from spy16

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding notification worker e2e test
3 participants
@mabdh @coveralls @rahmatrhd