Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallelize notification handler goroutines #158

Open
mabdh opened this issue Nov 30, 2022 · 0 comments
Open

Parallelize notification handler goroutines #158

mabdh opened this issue Nov 30, 2022 · 0 comments
Assignees
@mabdh
Labels
enhancement New feature or request

Comments

@mabdh
Copy link
Member

mabdh commented Nov 30, 2022

Is your feature request related to a problem? Please describe.
Siren notification handler could fetch a batch size messages from the queue. It processes and send the message one by one, we could actually send the messages in parallel without the need in serializing them.

Describe the solution you'd like
Use errgroup to send messages in parallel
@mabdh mabdh self-assigned this Nov 30, 2022
@mabdh mabdh added the enhancement New feature or request label Nov 30, 2022
@mabdh mabdh linked a pull request Nov 30, 2022 that will close this issue
feat(notification): add notification worker e2e test #156
Merged
@mabdh mabdh removed a link to a pull request Dec 1, 2022
feat(notification): add notification worker e2e test #156
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mabdh mabdh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mabdh